Add ability to add global loading spinner to application(s) #4659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4659 +/- ##
===========================================
- Coverage 83.19% 70.60% -12.60%
===========================================
Files 264 266 +2
Lines 37351 37415 +64
===========================================
- Hits 31076 26416 -4660
- Misses 6275 10999 +4724
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 68 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
force-pushed
the
global_loading_spinner
branch
from
9aca7eb
to
c4a8340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In converted pyodide applications we have had the ability to add a global loading indicator for a long time. There is no reason not to also support it for other applications that may take a little while to load.